Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove "$0" string from pricing strikeout #895

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

katrinan029
Copy link
Contributor

@katrinan029 katrinan029 commented Dec 11, 2023

Remove extraneous "$0" string from price strikeout.

Before After
Screenshot 2023-12-11 at 12 26 27 PM Screenshot 2023-12-11 at 12 26 39 PM

JIRA Ticket

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@katrinan029 katrinan029 marked this pull request as ready for review December 11, 2023 20:45
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 109 lines in your changes are missing coverage. Please review.

Comparison is base (d36b78a) 84.87% compared to head (fbef67f) 85.17%.
Report is 97 commits behind head on master.

Files Patch % Lines
...ntent/course-enrollments/CourseAssignmentAlert.jsx 27.27% 8 Missing ⚠️
src/components/course/data/hooks.jsx 88.13% 7 Missing ⚠️
...course-enrollments/course-cards/BaseCourseCard.jsx 89.85% 7 Missing ⚠️
src/components/my-career/VisualizeCareer.jsx 74.07% 6 Missing and 1 partial ⚠️
src/components/my-career/data/service.js 56.25% 7 Missing ⚠️
src/components/course/data/utils.jsx 95.89% 6 Missing ⚠️
src/components/my-career/AddJobRole.jsx 60.00% 5 Missing and 1 partial ⚠️
src/components/my-career/data/hooks.jsx 50.00% 6 Missing ⚠️
...n-content/course-enrollments/CourseEnrollments.jsx 84.37% 5 Missing ⚠️
...components/enterprise-user-subsidy/data/service.js 0.00% 5 Missing ⚠️
... and 27 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #895      +/-   ##
==========================================
+ Coverage   84.87%   85.17%   +0.30%     
==========================================
  Files         320      336      +16     
  Lines        6399     7024     +625     
  Branches     1552     1721     +169     
==========================================
+ Hits         5431     5983     +552     
- Misses        941     1010      +69     
- Partials       27       31       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@katrinan029 katrinan029 merged commit 4eec3cc into master Dec 11, 2023
6 checks passed
@katrinan029 katrinan029 deleted the knguyen2/ent-8094 branch December 11, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants